apollo_network_benchmark: added ping latency metrics#11548
Open
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_network_event_metricsfrom
Conversation
This was referenced Jan 8, 2026
Contributor
Author
This was referenced Jan 8, 2026
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
9fa62de to
5261825
Compare
a14d2e6 to
5e4a06d
Compare
5261825 to
f6b5f12
Compare
5e4a06d to
4cf8b68
Compare
This was referenced Feb 19, 2026
4cf8b68 to
c5160fd
Compare
c5160fd to
3bad93e
Compare
0789a94 to
21df92c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Low risk: adds a new Prometheus histogram and wires it into
NetworkMetricsfor the benchmark node, without changing networking behavior or data handling.Overview
Adds a
ping_latency_secondshistogram metric to the broadcast network stress test node and wires it into the exportedapollo_network::metrics::NetworkMetricsviaLatencyMetrics(previouslylatency_metricswasNone). This enables the benchmark to record and export ping latency alongside existing broadcast/SQMR/event metrics.Written by Cursor Bugbot for commit 3bad93e. This will update automatically on new commits. Configure here.