Skip to content

apollo_network_benchmark: added ping latency metrics#11548

Open
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_network_event_metricsfrom
01-07-apollo_network_benchmark_added_ping_latency_metrics
Open

apollo_network_benchmark: added ping latency metrics#11548
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_network_event_metricsfrom
01-07-apollo_network_benchmark_added_ping_latency_metrics

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Jan 8, 2026

Note

Low Risk
Low risk: adds a new Prometheus histogram and wires it into NetworkMetrics for the benchmark node, without changing networking behavior or data handling.

Overview
Adds a ping_latency_seconds histogram metric to the broadcast network stress test node and wires it into the exported apollo_network::metrics::NetworkMetrics via LatencyMetrics (previously latency_metrics was None). This enables the benchmark to record and export ping latency alongside existing broadcast/SQMR/event metrics.

Written by Cursor Bugbot for commit 3bad93e. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

sirandreww-starkware commented Jan 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review January 8, 2026 17:42
@sirandreww-starkware sirandreww-starkware self-assigned this Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 8, 2026
@github-actions github-actions bot closed this Feb 16, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_network_event_metrics branch from 9fa62de to 5261825 Compare February 16, 2026 09:10
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_ping_latency_metrics branch from a14d2e6 to 5e4a06d Compare February 16, 2026 09:10
@github-actions github-actions bot removed the stale label Feb 17, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_network_event_metrics branch from 5261825 to f6b5f12 Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_ping_latency_metrics branch from 5e4a06d to 4cf8b68 Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_ping_latency_metrics branch from 4cf8b68 to c5160fd Compare February 19, 2026 08:04
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_ping_latency_metrics branch from c5160fd to 3bad93e Compare March 16, 2026 15:13
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_network_event_metrics branch from 0789a94 to 21df92c Compare March 16, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants